perf: skip unnecessary access to cssText property #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! It's not clear which weekend I'll have time to do another round of jsdom releases, but I am excited to merge this (after testing it with the full jsdom test suite) as soon as I do have such time. |
|
Hi @domenic, thank you for taking care of that. |
domenic
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating slow tests in my project written with React + Chakra UI, I found out that calling the get accessor of
cssTextproperty takes up a large portion of total execution time. This PR is to skip such calls when possible by making_onChangecalls conditional.In my project, I saw ~40% improvement of the execution time (24sec → 15sec).