Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing value units #131

Closed
wants to merge 1 commit into from
Closed

Add missing value units #131

wants to merge 1 commit into from

Conversation

cdoublev
Copy link

@cdoublev cdoublev commented Apr 25, 2021

  • add missing <length> units lh, vmin, vmax, Q
  • sort <length> units by alpha order
  • add <angle> unit turn with corresponding logic to resolve to deg

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2021

Codecov Report

Merging #131 (fa6bdc4) into master (b527ed7) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   37.39%   37.33%   -0.07%     
==========================================
  Files          87       87              
  Lines        1182     1184       +2     
  Branches      227      228       +1     
==========================================
  Hits          442      442              
- Misses        633      634       +1     
- Partials      107      108       +1     
Impacted Files Coverage Δ
lib/parsers.js 80.24% <50.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b527ed7...fa6bdc4. Read the comment docs.

@cdoublev cdoublev mentioned this pull request May 10, 2021
@cdoublev
Copy link
Author

Superseded by #140.

@cdoublev cdoublev closed this May 13, 2021
@cdoublev cdoublev deleted the issue-3 branch June 11, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants