Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code missing from repo but present on NuGet #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matdavies
Copy link
Collaborator

These changes were decompiled using dotpeek. Chances are these changes were made on Jake's machine directly, then published direct to NuGet, but the code was never pushed to GitHub. If ever SqlObjectHydrator needs to change again, the changes should be based on this branch

@jrote1
Copy link
Owner

jrote1 commented Feb 6, 2020

Was there something specific missing, a lot of changes seem like moving of files etc.

Sorry if forgot to push some changes

Also could you exclude .vs folder

These changes were decompiled using dotpeek.  Chances are these changes were made on Jake's machine directly, then published direct to NuGet, but the code was never pushed to GitHub.  If ever SqlObjectHydrator needs to change again, the changes should be based on this branch
@matdavies matdavies force-pushed the ChangesThatExistOnNuGetButAbsentFromRepository branch from 4d785a2 to 11d056e Compare February 6, 2020 16:05
@matdavies
Copy link
Collaborator Author

He's alive! :) I think SafeTypeMapsAdd was added here?

Have removed the .vs folder, and actually, I didn't mean to create the PR into the main repo here - meant to create it into the LT fork, so feel free to close this off if you want.

@jrote1
Copy link
Owner

jrote1 commented Feb 6, 2020

That I am haha

That's annoying that forget to push as all the TypeMaps are tested, so would have lost that test aswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants