Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document security risks of eavesdropping #1834

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Document security risks of eavesdropping #1834

merged 3 commits into from
Nov 27, 2023

Conversation

utopiatopia
Copy link
Contributor

This is a documentations change that is supposed to resolve #1793. It not only documents what a system administrator can do in terms of reading a journal, but also includes other risks (like shoulder-surfing). Furthermore, I grouped "Plausible Deniability" and this new section together, as it seemed fitting. The risks of weak passwords bring might also belong in this section as well.

On another note, I literally don't know how to use developer tools (e.g. Git, poetry) or how collaborative projects work well enough to work on collaborative projects, so pardon me for anything I did wrong.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@utopiatopia utopiatopia changed the title Add security risks of eavesdropping Document security risks of eavesdropping Nov 26, 2023
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @utopiatopia, thanks for the PR, and congrats on your first jrnl PR! It looks great and I see nothing wrong with your process. You've documented your reasoning in the PR and explained your actions in your commit message, which is exactly what I love to see.

While previewing these docs, I thought the rather advanced "Shell History" section overshadowed the more entry-level paragraphs that followed, so I moved those paragraphs, along with your new section, up to the top. Otherwise, no notes from me, and no further action needed from you on this. The docs changes will show up with the next jrnl release.

@micahellison micahellison merged commit 434c320 into jrnl-org:develop Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document security risks of using a computer that someone else has admin access to
2 participants