Code

V2#9

Code

Open

jridgewell wants to merge 141 commits intomasterjridgewell/minionette:masterfrom v2jridgewell/minionette:v2Copy head branch name to clipboard

+1,840-1,087

Commits

Commits on Dec 14, 2014

• Reduce JSHint

  jridgewell

  committed
  0cc6803

  Copy full SHA for 0cc6803

• Convert to using Gulp

  jridgewell

  committed
  8c29828

  Copy full SHA for 8c29828

• Reformat switch statement

  jridgewell

  committed
  d8f87cf

  Copy full SHA for d8f87cf

• Simplify attempt()

  jridgewell

  committed
  3263785

  Copy full SHA for 3263785

• Remove spy on private method

  jridgewell

  committed
  e1fc468

  Copy full SHA for e1fc468

• Simplify CollectionView rendering

  jridgewell

  committed
  d6ea8cc

  Copy full SHA for d6ea8cc

• Split frag and view methods

  jridgewell

  committed
  2211dc3

  Copy full SHA for 2211dc3

• Update Region

  jridgewell

  committed
  b152d93

  Copy full SHA for b152d93

• Fully test view's events

  jridgewell

  committed
  9794b8e

  Copy full SHA for 9794b8e

• Don't extend ModelView if it's not needed.

  jridgewell

  committed
  64f301c

  Copy full SHA for 64f301c

• Add jshint for tests folder

  jridgewell

  committed
  5662e5c

  Copy full SHA for 5662e5c

• Fix collection spec

  jridgewell

  committed
  624b38a

  Copy full SHA for 624b38a

• Optimize view removal

  jridgewell

  committed
  4d4ac4c

  Copy full SHA for 4d4ac4c

• Refactor collection specs

  jridgewell

  committed
  7232ecd

  Copy full SHA for 7232ecd

• Remove unused path

  jridgewell

  committed
  f705b4a

  Copy full SHA for f705b4a

• Remove unnecessary micro-opts from attempt

  jridgewell

  committed
  d28532c

  Copy full SHA for d28532c

• Add comment

  jridgewell

  committed
  5e3ec0f

  Copy full SHA for 5e3ec0f

• Remove unneeded this contexts

  jridgewell

  committed
  90514e9

  Copy full SHA for 90514e9

• Fully spec Model

  jridgewell

  committed
  1e9d8eb

  Copy full SHA for 1e9d8eb

• Fix model specs

  jridgewell

  committed
  49b5edd

  Copy full SHA for 49b5edd

• Comment Computed

  jridgewell

  committed
  6a6c33b

  Copy full SHA for 6a6c33b

• Cleanup Model

  jridgewell

  committed
  a23431d

  Copy full SHA for a23431d

• Comment and spec Router

  jridgewell

  committed
  b55daab

  Copy full SHA for b55daab

• Setup code coverage through CodeClimate

  jridgewell

  committed
  4c0bba6

  Copy full SHA for 4c0bba6

• Add coveralls code coverage back

  jridgewell

  committed
  c04b9e1

  Copy full SHA for c04b9e1

• Add node flag to jshint

  jridgewell

  committed
  17f1eb5

  Copy full SHA for 17f1eb5

• Remove unnecessary _.result

  jridgewell

  committed
  76cbf49

  Copy full SHA for 76cbf49

• Generate clove + html code coverage

  jridgewell

  committed
  e19aa0c

  Copy full SHA for e19aa0c

• Remove unused code path

  jridgewell

  committed
  4188089

  Copy full SHA for 4188089

• Ensure a ParentClass does not affect Child's computed properties

  jridgewell

  committed
  d5fbee6

  Copy full SHA for d5fbee6

• Test that a view cannot become unattached

  jridgewell

  committed
  889a851

  Copy full SHA for 889a851

• Add missing tests

  jridgewell

  committed
  2c49ee4

  Copy full SHA for 2c49ee4

Commits on Dec 15, 2014

• Rename attempt's variables

  jridgewell

  committed
  a6ddbc4

  Copy full SHA for a6ddbc4

• Fix typo

  jridgewell

  committed
  8891309

  Copy full SHA for 8891309

• Split apart route parsing and action routing

  jridgewell

  committed
  979a82d

  Copy full SHA for 979a82d

• Do not limit regions to just the placeholder#el's parentElement

  jridgewell

  committed
  b763c22

  Copy full SHA for b763c22

• tmp

  jridgewell

  committed
  1ac7f1e

  Copy full SHA for 1ac7f1e

• Clean up

  jridgewell

  committed
  893f7d5

  Copy full SHA for 893f7d5

• Small refactor of CollectionView

  jridgewell

  committed
  b009361

  Copy full SHA for b009361

• Remove _parent tests

  jridgewell

  committed
  2c0a188

  Copy full SHA for 2c0a188

• Refactor #buildModelView specs

  jridgewell

  committed
  52024a7

  Copy full SHA for 52024a7

• Let the collectionView build it's document fragment

  jridgewell

  committed
  a716a92

  Copy full SHA for a716a92

• Sprinkle in some comments

  jridgewell

  committed
  7c4e262

  Copy full SHA for 7c4e262

• Remove passing in Region's cid

  jridgewell

  committed
  cf36523

  Copy full SHA for cf36523

• Don't test _regions

  jridgewell

  committed
  4669265

  Copy full SHA for 4669265

• Simplify instantiating a PlaceholderView

  jridgewell

  committed
  49677f9

  Copy full SHA for 49677f9

• Rename internal method

  jridgewell

  committed
  7d5ea44

  Copy full SHA for 7d5ea44

• Comment and spec new CollectionView features

  jridgewell

  committed
  012ebd9

  Copy full SHA for 012ebd9

• Steal megawac's parent finding

  Show description for 3925c08
  jridgewell

  committed
  3925c08

  Copy full SHA for 3925c08

Commits on Dec 18, 2014

• Rearrange and comment CollectionView

  jridgewell

  committed
  fa37973

  Copy full SHA for fa37973

• Make the emptyView management functions private

  jridgewell

  committed
  da0c2e5

  Copy full SHA for da0c2e5

• Fully test View's events

  jridgewell

  committed
  b94e08c

  Copy full SHA for b94e08c

• Use a separate event prefix for emptyView

  jridgewell

  committed
  800828c

  Copy full SHA for 800828c

• Add trigger() function

  Show description for 4edabb0
  jridgewell

  committed
  4edabb0

  Copy full SHA for 4edabb0

• Fix typo

  jridgewell

  committed
  5319f3c

  Copy full SHA for 5319f3c

• Add event splitter support.

  jridgewell

  committed
  82af323

  Copy full SHA for 82af323

• Test trigger()

  jridgewell

  committed
  7f87f56

  Copy full SHA for 7f87f56

• Fully test collection view EmptyView

  jridgewell

  committed
  78b6d89

  Copy full SHA for 78b6d89

• Extend EmptyView from Minionette.View

  jridgewell

  committed
  58f9588

  Copy full SHA for 58f9588

• Spec trigger() as a function

  jridgewell

  committed
  e606ea8

  Copy full SHA for e606ea8

• Optimize trigger

  jridgewell

  committed
  e003420

  Copy full SHA for e003420

• No need to explicitly return void 0

  jridgewell

  committed
  25ea0b8

  Copy full SHA for 25ea0b8

• UMD-ify

  Show description for 1b3905f
  jridgewell

  committed
  1b3905f

  Copy full SHA for 1b3905f

• Separate out regex splitters

  jridgewell

  committed
  1e3901d

  Copy full SHA for 1e3901d

• Document Computed, Model, and Router

  jridgewell

  committed
  e393807

  Copy full SHA for e393807

Commits on Dec 19, 2014

• Revise docs

  jridgewell

  committed
  5c8b61c

  Copy full SHA for 5c8b61c

• Add trigger docs

  jridgewell

  committed
  7193979

  Copy full SHA for 7193979

• Revamp View docs

  jridgewell

  committed
  c4f1929

  Copy full SHA for c4f1929

Commits on Dec 20, 2014

• Comment trigger

  jridgewell

  committed
  59b25d8

  Copy full SHA for 59b25d8

• Remove unnecessary param

  jridgewell

  committed
  47c2dd1

  Copy full SHA for 47c2dd1

• Move selector plucking into Placeholder's #initialize

  jridgewell

  committed
  4cc52ce

  Copy full SHA for 4cc52ce

• Build a region

  jridgewell

  committed
  b03fbcc

  Copy full SHA for b03fbcc

• Specs

  jridgewell

  committed
  7a8fbfa

  Copy full SHA for 7a8fbfa

• Test subview's 'remove' / 'removed' events

  jridgewell

  committed
  99fd2e2

  Copy full SHA for 99fd2e2

• Remove false positives

  jridgewell

  committed
  8ef20c2

  Copy full SHA for 8ef20c2

• Cleanup comments

  jridgewell

  committed
  373adcd

  Copy full SHA for 373adcd

• Pass our arguments to super

  jridgewell

  committed
  0141d18

  Copy full SHA for 0141d18

• Fix bug with a collectionView's #remove

  Show description for c5f5ee5
  jridgewell

  committed
  c5f5ee5

  Copy full SHA for c5f5ee5

Commits on Dec 21, 2014

• Bump and cleanup dependencies

  jridgewell

  committed
  55524ed

  Copy full SHA for 55524ed

• Fix router spec with Backbone 1.1.2

  jridgewell

  committed
  52afc40

  Copy full SHA for 52afc40

• Use svg build status icon

  jridgewell

  committed
  921110a

  Copy full SHA for 921110a

• tmp

  jridgewell

  committed
  d947a8d

  Copy full SHA for d947a8d

Commits on Dec 23, 2014

• Implement faster #render

  Show description for 51718e9
  jridgewell

  committed
  51718e9

  Copy full SHA for 51718e9

• Don't use global $.

  Show description for 4361101
  jridgewell

  committed
  4361101

  Copy full SHA for 4361101

• Uniquely identify any region's element

  jridgewell

  committed
  e02479c

  Copy full SHA for e02479c

• Use chain syntax.

  jridgewell

  committed
  4af3589

  Copy full SHA for 4af3589

• Add #placeholder to support view template helper

  jridgewell

  committed
  d4f636b

  Copy full SHA for d4f636b

• Use a div for old elements container

  jridgewell

  committed
  86aade8

  Copy full SHA for 86aade8

• Support unrendered selectors

  jridgewell

  committed
  63250fb

  Copy full SHA for 63250fb

• Update specs

  jridgewell

  committed
  930ddac

  Copy full SHA for 930ddac

• Fix broken specs

  jridgewell

  committed
  12c7519

  Copy full SHA for 12c7519

• Update a region's view.

  jridgewell

  committed
  bf3cd97

  Copy full SHA for bf3cd97

• Remove unneeded conditional

  jridgewell

  committed
  633510a

  Copy full SHA for 633510a

• Special case childless nodes

  jridgewell

  committed
  e1e8ff0

  Copy full SHA for e1e8ff0

• Test render throwing when a region's selector isn't found

  jridgewell

  committed
  a82cecd

  Copy full SHA for a82cecd

• Add Region#render back

  jridgewell

  committed
  2adda37

  Copy full SHA for 2adda37

• Cleanup attribute reduction

  jridgewell

  committed
  2c5ed73

  Copy full SHA for 2c5ed73

Commits on Jan 3, 2015

• Throw error when using view template helper with selector region

  jridgewell

  committed
  448e251

  Copy full SHA for 448e251

Commits on Apr 22, 2015

• Add ...rest helper

  jridgewell

  committed
  ca5ec61

  Copy full SHA for ca5ec61

• Remove precheck from attempt

  jridgewell

  committed
  fd8e888

  Copy full SHA for fd8e888

• Computeds can have getter and setter

  Show description for 9d6592c
  jridgewell

  committed
  9d6592c

  Copy full SHA for 9d6592c

• Cleanup region

  jridgewell

  committed
  946b03d

  Copy full SHA for 946b03d

• Build region options

  jridgewell

  committed
  03c9be3

  Copy full SHA for 03c9be3

• Fix _updateRegionView

  jridgewell

  committed
  022bc53

  Copy full SHA for 022bc53

Commits on May 1, 2015

• Remove Computed Setters

  Show description for cf10678
  jridgewell

  committed
  cf10678

  Copy full SHA for cf10678

• Ensure a reseted Region has the default #selector and #placeholder

  jridgewell

  committed
  144aebd

  Copy full SHA for 144aebd

• Region's don't need a parent

  jridgewell

  committed
  e2cfee7

  Copy full SHA for e2cfee7

• Classes can no longer be passed in via options

  jridgewell

  committed
  3d2fbe6

  Copy full SHA for 3d2fbe6

• Remove #buildRegionOptions

  jridgewell

  committed
  d4da2a6

  Copy full SHA for d4da2a6

• Pass in region, not regionName

  Show description for db9f0e5
  jridgewell

  committed
  db9f0e5

  Copy full SHA for db9f0e5

• emptyViews have a parent

  jridgewell

  committed
  b4c3432

  Copy full SHA for b4c3432

• Stop listening to a removed emptyView

  jridgewell

  committed
  2955342

  Copy full SHA for 2955342

• Use rest() in #_forwardEvents

  jridgewell

  committed
  0fbb5d9

  Copy full SHA for 0fbb5d9

• Whitespace

  jridgewell

  committed
  6d7c938

  Copy full SHA for 6d7c938

• Remove Region -> Parent View property

  jridgewell

  committed
  16d75ab

  Copy full SHA for 16d75ab

• Remove View -> Parent Region property

  jridgewell

  committed
  cb2f3ee

  Copy full SHA for cb2f3ee

• Use #on instead of #stopListening

  jridgewell

  committed
  4225185

  Copy full SHA for 4225185

• Allow #_renderEmptyView to determine if emptyView should be rendered

  jridgewell

  committed
  2f69d9b

  Copy full SHA for 2f69d9b

• Remove ModelView -> Parent CollectionView property

  jridgewell

  committed
  848a3ea

  Copy full SHA for 848a3ea

• Support emptyView and modelViews in #_removeView

  jridgewell

  committed
  40a2058

  Copy full SHA for 40a2058

• Consolidate similar methods

  jridgewell

  committed
  56bde41

  Copy full SHA for 56bde41

• Render the emptyview on 'remove' event

  jridgewell

  committed
  152276d

  Copy full SHA for 152276d

• Remove #_removeFromParent

  jridgewell

  committed
  b964b7d

  Copy full SHA for b964b7d

Commits on Aug 7, 2015

• Bump devDependencies

  jamiebuilds

  committed
  b62fcf2

  Copy full SHA for b62fcf2

• Babelify gulpfile

  jamiebuilds

  committed
  8b1c9eb

  Copy full SHA for 8b1c9eb

• Use Babel and esperanto

  jamiebuilds

  committed
  4a48672

  Copy full SHA for 4a48672

• Fix deps in collection view

  jamiebuilds

  committed
  382ef33

  Copy full SHA for 382ef33

• Use more ES6

  jamiebuilds

  committed
  56e0611

  Copy full SHA for 56e0611

• Remove build file

  jamiebuilds

  committed
  cb454d5

  Copy full SHA for cb454d5

• A lil more es6

  jamiebuilds

  committed
  5779b4f

  Copy full SHA for 5779b4f

• Merge pull request #15 from thejameskyle/tjk/build

  Show description for 8a9e134
  jridgewell

  committed
  8a9e134

  Copy full SHA for 8a9e134

• Drop Model and Computed

  jridgewell

  committed
  7d94201

  Copy full SHA for 7d94201

• Remove rest in favor of ES6 rest param

  jridgewell

  committed
  75d00a6

  Copy full SHA for 75d00a6

• ES6 cleanups

  jridgewell

  committed
  d2b2e41

  Copy full SHA for d2b2e41

• Wrap *Events in a function

  jridgewell

  committed
  46ea037

  Copy full SHA for 46ea037

• Set UI elements on #setElement

  jridgewell

  committed
  3305399

  Copy full SHA for 3305399

• Update DOM attributes of root on render

  jridgewell

  committed
  66fe236

  Copy full SHA for 66fe236

Commits on Nov 2, 2015

• Remove documentFragment support

  jridgewell

  committed
  39503e0

  Copy full SHA for 39503e0

• Remove Router

  jridgewell

  committed
  d79fea1

  Copy full SHA for d79fea1

• Remove remove:internal event

  jridgewell

  committed
  de55fc9

  Copy full SHA for de55fc9

Commits on Nov 3, 2015

• Remove region view helper

  jridgewell

  committed
  29e7c07

  Copy full SHA for 29e7c07