[FreshEyes] test: Validate UTXO snapshot with coin height > base height & amount > MAX_MONEY supply #2
Conversation
… money_supply You can use this tool to decode the utxo snapshot https://github.com/jrakibi/utxo-live Here’s an overview of how it’s done: The serialization forma for a UTXO in the snapshot is as follows: 1. Transaction ID (txid) - 32 bytes 2. Output Index (outnum)- 4 bytes 3. VARINT (code) - A varible-length integer encoding the height and whether the transaction is a coinbase. The format of this VARINT is (height << 1) | coinbase_flag. 4. VARINT (amount_v) - A variable-length integer that represents a compressed format of the output amount (in satoshis). For the test cases mentioned: * b"\x84\x58" - This value corresponds to a VARINT representing the height and coinbase flag. Once we decode this code, we can extract the height and coinbase using height = code_decoded >> 1 and coinbase = code_decoded & 0x01. In our case, with code_decoded = 728, it results in height = 364 and coinbase = 0. * b"\xCA\xD2\x8F\x5A" - This byte sequence represents a compressed amount value. The decompression function takes this value and translates it into a full amount in satoshis. In our case, the decompression of this amount translates to a number larger than the maximum allowed value of coins (21 million BTC) test:Validate UTXO snapshot with coin_height > base_height & amount > money_supply test:Validate UTXO snapshot with coin_height > base_height & amount > money_supply
|
An author commented here with:
|
|
An author commented here with:
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
![fresheyes-staging-bot[bot]](https://avatars.githubusercontent.com/in/855196?s=60&v=4){kind=small}
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
An author commented here with:
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
An author commented here with:
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
The author jrakibi wrote the following PR called test: Validate UTXO snapshot with coin height > base height & amount > MAX_MONEY supply, issue number 29617 in bitcoin/bitcoin cloned by FreshEyes below:
Ensure snapshot loading fails for coins exceeding base height
Objective: This test verifies that snapshot loading is correctly rejected for coins with a height greater than the base height.
Update:
test_invalid_snapshot_wrong_coin_codetofeature_assumeutxo.py.This implementation addresses the request for enhancing
assumeutxotesting as outlined in issue#28648Edit: This is an explanation on how I arrive at content values: b"\x84\x58" and b"\xCA\xD2\x8F\x5A"
You can use this tool to decode the utxo snapshot
https://github.com/jrakibi/utxo-liveHere’s an overview of how it’s done:
The serialization format for a UTXO in the snapshot is as follows:
For the test cases mentioned:
b"\x84\x58"- This value corresponds to a VARINT representing the height and coinbase flag. Once we decode this code, we can extract the height and coinbase usingheight = code_decoded >> 1andcoinbase = code_decoded & 0x01. In our case, with code_decoded = 728, it results inheight = 364andcoinbase = 0.b"\xCA\xD2\x8F\x5A"- This byte sequence represents a compressed amount value. The decompression function takes this value and translates it into a full amount in satoshis. In our case, the decompression of this amount translates to a number larger than the maximum allowed value of coins (21 million BTC)