Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker: Added Mongolian localisation #1883

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knutsenm
Copy link

@knutsenm knutsenm commented Mar 4, 2019

No description provided.

@jsf-clabot
Copy link

jsf-clabot commented Mar 4, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@dmethvin
Copy link
Member

Not sure why the CLA bot is hung up. I'll leave this open, not sure of our plans to add more i18n locales yet.

@fnagel
Copy link
Member

fnagel commented Dec 9, 2019

As calendar and datepicker rewrite is not really ready I would say lets add new localization files for datepicker (there is another one, see #1899).

@arschmitz What's your opinion on this?

@arschmitz @dmethvin Do we have a policy about reviewing the actual translated sentences / words?

@fnagel fnagel self-assigned this Dec 9, 2019
@fnagel
Copy link
Member

fnagel commented Jan 14, 2020

@arschmitz @dmethvin @mgol Any feedback on this?

@fnagel fnagel mentioned this pull request Jan 14, 2020
@mgol
Copy link
Member

mgol commented Jan 14, 2020

@fnagel I'm not sure what was the strategy for adding new locales to UI. In principle I don't see anything wrong with it but I feel it's something to decide for the UI team itself.

@knutsenm
Copy link
Author

@fnagel I can confirm that the translations were vetted by a native Mongolian speaker

@fnagel
Copy link
Member

fnagel commented Mar 23, 2020

We agreed on adding new language files but need some more verification the localization is fine. Please see here: https://jqueryui.pbworks.com/w/page/139157592/Adding%20translations

@knutsenm
Copy link
Author

I'm afraid I can't help you further except to give a few more details: I created this translation with the help of online tools, then had it vetted by a native Mongolian speaker that my organization trusts. We use it ourselves.

@fnagel
Copy link
Member

fnagel commented Mar 23, 2020

Sounds good. I will try to organize someone else to review and we should be good to go.

Thanks for the quick response!

Base automatically changed from master to main February 19, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants