Bugfix for term.split_seqs('term.right(3)') #197 #199
Conversation
In version 1.18.0 and earlier, >> term.split_seqs(term.move_right(333) + 'xyz', maxsplit=1) ['\x1b[333C', '333', 'xyz'] This is a bug, it duplicates the matched parameter, this is now corrected: ['\x1b[3C', 'xyz'] Previously, we documented "same arguments as "re.split", so we must also implement maxsplit and flags. Also, - fix flake8 linting of tests by moving fixtures to conftest.py, fixes "unused" or "re-definition from import" errors. - version stamp blessed/__init__.py like a codegen step i guess - remove run_codecov.py, its been fixed upstream codecov/codecov-python#158 (comment)
| @@ -0,0 +1,24 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Probably better than maintaining it in two places, but what is version.json used for? I typically set __version__ in __init__.py and parse it in setup.py.
There was a problem hiding this comment.
There was a problem hiding this comment.
Here's what I do for enlighten. Same for most of the packages I maintain.
https://github.com/Rockhopper-Technologies/enlighten/blob/master/setup_helpers.py#L21-L32
https://github.com/Rockhopper-Technologies/enlighten/blob/master/doc/conf.py#L64
https://github.com/Rockhopper-Technologies/enlighten/blob/master/setup.py#L29
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 95.68% 95.61% -0.07%
==========================================
Files 9 9
Lines 996 1004 +8
Branches 160 163 +3
==========================================
+ Hits 953 960 +7
Misses 40 40
- Partials 3 4 +1
Continue to review full report at Codecov.
|
|
I guess this needs to be updated too |
|
Going to pull this down and give it a shot this evening. Thanks! 🤘 |
Oh, sorry. I missed that. |
In version 1.18.0 and earlier,
This is a bug (#197) it duplicates the matched parameter, this is now corrected:
Also,
fixes "unused" or "re-definition from import" errors.
Retry uploads on (connection) errors codecov/codecov-python#158 (comment)