Define __all__ to re-export classes #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes:
behave properly for type checkers like pyright by conforming to the PEP561 / type information in libraries spec. Linters also stop complaining, so you can remove the #noqa.
Without the change, pyright reports:
error: "JinjaX" is not exported from module "jinjax" (reportPrivateImportUsage)
This can be worked around by ignoring the
reportPrivateImportUsage
rule, but it's nice to have.An alternative to setting
__all__
would be redundant aliases (e.g.from .jinjax import JinjaX as JinjaX
) but I figured those were less nice.microsoft/pyright#2639 (comment)