Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove single file upload #1957

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Remove single file upload #1957

merged 1 commit into from
Aug 30, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Aug 30, 2024

This PR removes the ability to just upload an overview.json file without the comparisons mentioned in it.

Some reasons for this include:

  • Errors when the user tries to open a comparison in the table, since the files for the comparison are missing
  • The lecturer possibly making decisions just based on the percentages in the table and not the actual code
  • The local mode, starting the viewer with the zip directly and thus uploading a single file, being even more rare

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Aug 30, 2024
@tsaglam tsaglam merged commit 9a1287e into develop Aug 30, 2024
49 checks passed
@tsaglam tsaglam deleted the report-viewer/remove-single-file branch August 30, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuchss dfuchss dfuchss approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kr0nox @dfuchss @tsaglam