Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide radar chart when not enough members #1414

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Dec 5, 2023

This PR updates the radar chart.

The dropdown now only lets you select members of the cluster, which have at least comparisons in the cluster.
If no such person exists, the chart is not shown at all and replaced by a text explaining why it is missing.
There now is a explanation about missing comparisons below the cluster if it is relevant for this cluster.
A general explanation of the chart was added below the cluster.

If the cluster view ist not showable due to having no valid members, the cluster view hides the selector for the cluster visualization

Copy link

sonarcloud bot commented Dec 7, 2023

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kr0nox Kr0nox marked this pull request as ready for review December 7, 2023 13:04
@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Dec 7, 2023
@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Dec 8, 2023
@Kr0nox Kr0nox added this to the v5.0.0 milestone Dec 8, 2023
@tsaglam tsaglam merged commit 5740f13 into develop Jan 10, 2024
21 checks passed
@tsaglam tsaglam deleted the report-viewer/hide-radar branch January 10, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants