Made the GreedyStringTiling class deterministic in case both submissi… #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons have the same amount of tokens.
tsaglam
added
enhancement
|
[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed! |
tsaglam
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The greedy string tiling class used to result in an arbitrary comparison direction if both submissions had the same amount of tokens. This did result in noticeable discrepancies in the similarity (see #1279). This PR fixes that by using the submission name as a tie breaker.
Also made some small changes removing warnings.