Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump vue-tsc to 1.8.15 #1321

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Bump vue-tsc to 1.8.15 #1321

merged 1 commit into from
Sep 28, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Sep 28, 2023

Replaces #1317

Since vue-tsc now has more restrictions in emits, this PR implements these.

@Kr0nox Kr0nox mentioned this pull request Sep 28, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sebinside
Copy link
Member

OK, but what about?

JPlag/report-viewer/src/views/ComparisonView.vue

Line 54 in 6eb1da8

@line-selected="showMatchInSecond"

@Kr0nox
Copy link
Member Author

Kr0nox commented Sep 28, 2023

Its is not standard to use camelCase for these html tags.

The Vue Documentation also does it the way we currently do it

@sebinside sebinside merged commit 94301a0 into develop Sep 28, 2023
17 checks passed
@sebinside sebinside deleted the report-viewer/bump-vue-tsc branch September 28, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebinside sebinside Awaiting requested review from sebinside

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kr0nox @sebinside