Some small e2e tests for report viewer #1280
Conversation
tsaglam
added
enhancement
|
[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!
|
|
@sebinside This PR is now ready for review. |
There was a problem hiding this comment.
At least for me, the tests fail locally with
Test timeout of 30000ms exceeded.
Error: page.waitForEvent: Page closed
waiting for event "filechooser"
but that could also be a configuration thing, playwright is not exactly lightweight :)
Other than this we should discuss which standards we want regarding code quality and comprehensiveness of these test cases in the next meeting. I see the benefit of direct feedback by the CI/CD pipeline if we break something. However, this can quickly develop into something hard to maintain and hard to keep up-to-date.
|
[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!
|
|
After merging the develop branch into this and trying to adapt the tests, I agree with @sebinside that the current construct is hard to maintain at times. In hindsight comparing screenshots should probably only be done for the entire page or elements with a constant size. Dynamically sized elements can have a different size on different machines. In addition I could not provide schreenshots for mac users, so this is another challange. I am against screenshotting the entire page, since it changes so rapidly, that every PR would update 20 images. Instead I opted for not doing a check for the cluster chart. For the distribution and the radar chart, we check, that the diagramm changes when it is supposed to. (change similarity, ...) |
|
Before merging this, develop should be merged into this branch again, even if there are no merge conflicts, to ensure the tests are all still correct |
|
|
@sebinside Merged and updated the test that were failing. Can be merged from my side |
This PR adds some small tests for the basic functionality of each page