Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Actions #1277

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Rework Actions #1277

merged 6 commits into from
Sep 5, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Sep 2, 2023

This PR changes all actions, that previosly did not, to only run when the underlying code changed.
I renamed the report-viwer-test action to report-viewer-build-test because since we also have actions for unit and e2e test and in my opinion the naming can be confusing. I also renamed the sonarcloud action for the report viewer to fit the naming sceme of the other report viewer actions.

In addition the report viewer sonarcloud scans do not get activated on dependabot PRs.

Fixes #1147

@Kr0nox Kr0nox requested a review from dfuchss September 2, 2023 12:16
@Kr0nox Kr0nox linked an issue Sep 2, 2023 that may be closed by this pull request
Copy link
Member

@dfuchss dfuchss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Maybe we can simplify the globs.

.github/workflows/maven.yml Outdated Show resolved Hide resolved
@Kr0nox Kr0nox requested a review from dfuchss September 4, 2023 06:58
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dfuchss dfuchss merged commit 88c94f2 into develop Sep 5, 2023
24 checks passed
@dfuchss dfuchss deleted the rework-actions branch December 6, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework Actions
2 participants