Adapt loop tokenization rules of the Java language module #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaglam
added
enhancement
# Conflicts: # languages/java/src/test/java/de/jplag/java/AbstractJavaLanguageTest.java
tsaglam
force-pushed
the
feature/loop-mapping
branch
from
46f2005
to
ab93663
Compare
…changes. Positive deviation over all AVG similarity values: count=120, average=0.0657, min=0.0357, max=0.1395.
|
[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed! |
TwoOfTwelve
reviewed
Aug 7, 2023
| J_FOR_BEGIN("FOR{"), // check | ||
| J_FOR_END("}FOR"), // check | ||
| J_LOOP_BEGIN("LOOP{"), // check | ||
| J_LOOP_END("}LOOP"), // check |
There was a problem hiding this comment.
Is there a reason for the comments saying "check"? Is that an old TODO marker?
There was a problem hiding this comment.
Those are legacy comments, I think they intend to show that this token is extracted correctly. We never threw them away so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, different loop types led to different loop tokens. This PR adapts the tokenization rules to utilize a single token type for each the start and end of loops.