docker run for busybox udhcpc: add --rm flag #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use --rm with "docker run", so the remaining container does not consume disk space after the command is done.
osmocom-gerrit
pushed a commit
to osmocom/docker-playground
that referenced
this pull request
Feb 14, 2022
Add "--rm" to each "docker run" command, so they don't continuously fill up disk space. Fix this even in the pipework script. We don't use the code path there, but by always having --rm after "docker run" (same line or next line), a new lint script in osmo-ci I8ab9c291504475d670bdefc50c4524c5bdd4c880 can help us avoid this in the future. In ttcn3-ggsn-test/jenkins.sh, move one existing --rm in a later line upwards so the linter can find it. Related: SYS#5827, OS#5099 Related: jpetazzo/pipework#248 Change-Id: I48b01c43fedf379b8a565eaab0369806d7831bd8
yoursunny
approved these changes
Mar 27, 2024
|
Hi! Thanks for the PR. I had missed the original notification a few years back 😅 I'm a bit on the fence about that one, because if something goes wrong, the container is going to be removed, which will prevent looking at its logs, and will be annoying from a debugging perspective. What do you think? |
|
Personally I think creating a container that does not get removed every time the script runs, is worse than that. I would suggest to rather redirect the log to a file for a better debugging experience. And maybe add a check that ensures udhcpc is actually running, and if it isn't, then print the log. With that being said, I won't work on this pull request further, so feel free to merge or close it as you prefer 🙂 Thanks for making pipework! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use --rm with "docker run", so the remaining container does not consume
disk space after the command is done.