-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onnx export with dynamic shapes, fast attention #324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpata
changed the title
enable onnx export via dynamo with dynamic shapes
onnx export of quantized model with dynamic shapes
May 25, 2024
3 tasks
… into fix_onnx_export
jpata
changed the title
onnx export of quantized model with dynamic shapes
onnx export with dynamic shapes, fast attention
May 27, 2024
3 tasks
farakiko
pushed a commit
to farakiko/particleflow
that referenced
this pull request
Aug 26, 2024
* enable onnx export via dynamo with dynamic shapes * added standalone export script * fp16 quantization sort of works also * use sdpa * MultiheadAttention op runs * update timing study * cleanup * model closes * update timing study * onnx is factorized * update onnx script * revert main model code * move to notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notebooks/cms/cms-validate-onnx.py
which contains a minimal, standalone version of the attention-based model, validated against the base model, and the exporting code to ONNX, with both unfused (default, slow) and fused (fast on GPU) attentionaten::scaled_dot_product_attention
op to use com.microsoft.MultiHeadAttention from ONNX contribHere's how the direct export of
torch.nn.functional.scaled_dot_product_attention
to an unfused ONNX model, with full matrix multiplications looks like:Using the SDPA fused operation that will use flash attention on sufficiently new GPUs, where the MatMul->Softmax->MatMul part in the very end is rolled into an op SDPA that calls MultiHeadAttention:
Here are the timings, showing the benefit of the fused model: