-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Search Functionality to Get All Companies Endpoint #42
Added Search Functionality to Get All Companies Endpoint #42
Conversation
tests/Feature/CompanyTest.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the most ideal way to do an integration test. In order to achieve full end to end testing, the database should not be mocked, but as the project itself has no test coverage, I guess this could suffice.
Hello @jovialcore, can you help take a look when you have the chance?. |
@jovialcore I guess I will need to rebase from main and fix the conflicts before you can have a look at this one. I would let you know once this is done |
Aite. |
… into move_search_functionality_to_BE
…obafemitayor/whatcompstack-BE into move_search_functionality_to_BE
… into move_search_functionality_to_BE
@jovialcore I have merge this PR with all the latest changes from master and it is now ready for a review. Here is also the related PR for the frontend changes |
tests/Feature/CompanyTest.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the most ideal way to do an integration test. In order to achieve full end to end testing, the database should not be mocked, but as the project itself has no test coverage, I guess this could suffice.
tests/Feature/CompanyTest.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the most ideal way to do an integration test. In order to achieve full end to end testing, the database should not be mocked, but as the project itself has no test coverage, I guess this could suffice.
@@ -6,27 +6,30 @@ | |||
use App\Http\Resources\CompanyResource; | |||
use App\Models\Company; | |||
|
|||
use App\Services\SearchService; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this as it is not used anywhere in this code
Alright. Will review. I appreciate it, @obafemitayor . |
Hi @obafemitayor thanks for the PR. I usually do some shoutout on X and LinkedIn. Do you mind if I get your @ for X and LinkedIn? |
Hello @jovialcore my LinkedIn is https://www.linkedin.com/in/obafemi-tayo-6296b28b |
Hello @jovialcore, I wanted to ask if you have deployed the latest backend changes to master. I visited the site now and I am seeing this |
Yeah. I am on it. seen that. been having issues with deploying. but I am on it |
@obafemitayor Fixed. It's done now. You can check again |
@jovialcore Yes it works now. Waiting for your Linkedin SO 😉😉 |
Sure sure 👏🏽😄. Thank you. |
Related Issue
Related PRs
What Changed
/company/stack/all
endpoint to follow standard REST guidelines. Confirmed that this would not cause any breaking changes on the front end.Testing Strategy
php artisan test --filter=CompanyTest
, for running the test in docker usedocker-compose run app php artisan test --filter=CompanyTest