build(mage): 🐛 only do renaming for deb package

build/magefiles/build.go

@@ -41,6 +41,7 @@ func (Build) Fast() error {
 	return buildProject()
 }
 
+// CI runs build steps required for building in a CI environment (i.e., GitHub).
 func (b Build) CI() error {
 	if !isCI() {
 		return ErrNotCI
@@ -53,30 +54,38 @@ func (b Build) CI() error {
 	return nil
 }
 
+// buildProject is the shared method that all exported build targets use. It
+// runs the bare minimum steps to build a binary of the agent.
+//
 //nolint:mnd
 func buildProject() error {
+	// Remove any existing dist directory.
 	if err := os.RemoveAll(distPath); err != nil {
 		return fmt.Errorf("could not clean dist directory: %w", err)
 	}
-
+	// Recreate an empty dist directory for this build.
 	if err := os.Mkdir(distPath, 0o755); err != nil {
 		return fmt.Errorf("could not create dist directory: %w", err)
 	}
 
+	// Set-up the build environment.
 	envMap, err := generateEnv()
 	if err != nil {
 		return errors.Join(ErrBuildFailed, err)
 	}
 
+	// Set-up appropriate build flags.
 	ldflags, err := getFlags()
 	if err != nil {
 		return errors.Join(ErrBuildFailed, err)
 	}
 
+	// Set an appropriate output file based on the arch to build for.
 	outputFile := filepath.Join(distPath, "/go-hass-agent-"+envMap["PLATFORMPAIR"])
 
 	slog.Info("Running go build...", "output", outputFile, "ldflags", ldflags)
 
+	// Run the build.
 	if err := sh.RunWithV(envMap, "go", "build", "-ldflags="+ldflags, "-o", outputFile); err != nil {
 		return fmt.Errorf("failed to build project: %w", err)
 	}

build/magefiles/helpers.go

@@ -197,6 +197,10 @@ func generateEnv() (map[string]string, error) {
 	return envMap, nil
 }
 
+// parseBuildPlatform reads the BUILDPLATFORM environment variable, which should
+// always be set, and extracts the value into appropriate GOOS, GOARCH and GOARM
+// (if applicable) variables.
+//
 //nolint:mnd
 func parseBuildPlatform() (operatingsystem, architecture, version string) {
 	var buildPlatform string

build/magefiles/package.go

@@ -63,7 +63,7 @@ func (Package) Nfpm() error {
 
 		// nfpm creates the same package name for armv6 and armv7 deb packages,
 		// so we need to rename them.
-		if envMap["GOARCH"] == "arm" {
+		if envMap["GOARCH"] == "arm" && pkgformat == "deb" {
 			debPkgs, err := filepath.Glob(distPath + "/pkg/*.deb")
 			if err != nil {
 				return fmt.Errorf("could not find arm deb package: %w", err)