Fix inheritance bug that doesn't reset state correctly #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What? ===== This addresses a bug with a very specific set of criteria for reproduction: * a page object (A) inheriting from PageEz::Page with a macro declaring a block (nothing needs to be declared in the block) * a page object (B) inheriting from PageEz::Page that declares a top-level macro named (X) * a page object (C) inheriting from (A) that also declares a top-level macro named (X) The bug that triggered this failure (a duplicate element declaration error, which would be on (X) in the example above) was related to a state change (setting nested_macro to true) when a block is provided to a macro that wasn't reset after the block was complete. When a class inherits from PageEz or its subclasses, if it's not nested, it resets all its visitors. This key behavior wasn't being triggered on (C), resulting in it finding the same macro (X) from (B) and determining that it was a collision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This addresses a bug with a very specific set of criteria for
reproduction:
a block (nothing needs to be declared in the block)
macro named (X)
macro named (X)
The bug that triggered this failure (a duplicate element declaration
error, which would be on (X) in the example above) was related to a
state change (setting nested_macro to true) when a block is provided to
a macro that wasn't reset after the block was complete.
When a class inherits from PageEz or its subclasses, if it's not nested,
it resets all its visitors. This key behavior wasn't being triggered on
(C), resulting in it finding the same macro (X) from (B) and determining
that it was a collision.