Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh: <esc> aliases #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enh: <esc> aliases #29

wants to merge 1 commit into from

Conversation

binury
Copy link

@binury binury commented Jul 1, 2024

Although they may seem custom, these bindings are built-ins

closes #22 & #24

@hyouuu
Copy link

hyouuu commented Aug 15, 2024

Given that the repo seems to be abandoned but is the only usable one (comparing to https://github.com/bernardo-bruning/godot-vim), should we use your fork as a base to include other open PRs and move forward @binury ?

hyouuu added a commit to hyouuu/godot-vim that referenced this pull request Aug 16, 2024
@hyouuu
Copy link

hyouuu commented Aug 16, 2024

Oops looks like I already forked this 4 months ago and just added your changes here: https://github.com/hyouuu/godot-vim feel free to use it if you like

@Matthew-Eucaristo
Copy link

Oops looks like I already forked this 4 months ago and just added your changes here: https://github.com/hyouuu/godot-vim feel free to use it if you like

Have tried yours, just replaced the godot-vim.gd and my lovely Ctrl+[ just worked like a charm 😍thank you @hyouuu

@eth4io
Copy link

eth4io commented Sep 13, 2024

Nice PR! I would suggest to not to commit the white space changes in your commit. It may down to personal preference but it's good to respect the original tab/space convention unless it's a dedicated space re-formatting PR.

@eth4io
Copy link

eth4io commented Sep 13, 2024

On another note, similar to this change, any chance anyone has figured out how to do sequential key mapping?

For instance in other VIM editors I mapped typing f then d within one second to Escape to exit insert mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants