Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dart highlighting support #229

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Dart highlighting support #229

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
334f971
Add Dart highlighting support
joshdick Jul 7, 2020
ed76f25
Fix a typo.
joshdick Jul 18, 2020
0fdfdf3
Merge branch 'master' into dartHighlighting
joshdick Jul 18, 2020
425443f
Remove custom Dart highlight group
joshdick Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions colors/onedark.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,17 @@ call s:h("cssSelectorOp", { "fg": s:purple })
call s:h("cssSelectorOp2", { "fg": s:purple })
call s:h("cssTagName", { "fg": s:red })

" Dart
call s:h("dartTypeDef", { "fg": s:red })
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dartTypeDef points to Typedef which already has highlighting in onedark.vim

call s:h("dartClassDecl", { "fg": s:red })
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dartClassDecl points to dartStorageClass which points to StorageClass, which already has highlighting in onedark.vim, so the first two are redundant

call s:h("dartInterpolation", { "fg": s:blue })
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dartInterpolation points to PreProc, which already has highlighting in onedark.vim

highlight link dartLibrary Include
call s:h("dartSdkClass", { "fg": s:cyan })
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dartSdkClass points to dartType which points to Type, which already has highlighting in onedark.vim

call s:h("dartStorageClass", { "fg": s:dark_red })
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See dartClassDecl.

highlight link dartExceptions Exception
highlight link dartStatement Statement
call s:h("dartConstant", { "fg": s:dark_yellow })
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dartConstant points to Constant, which already has highlighting in onedark.vim


" Fish Shell
call s:h("fishKeyword", { "fg": s:purple })
call s:h("fishConditional", { "fg": s:purple })
Expand Down