Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n for validation error messages and add lang option #277

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

i18n for validation error messages and add lang option #277

wants to merge 1 commit into from

Conversation

bearmini
Copy link

Add i18n for validation error messges using ajv-i18n.
Also add 'lang' option to choose which language will be used for the i18n.

@josdejong
Copy link
Owner

Thanks Takashi, I will review your PR as soon as possible.

@josdejong
Copy link
Owner

Your implementation looks neat,thanks.

I was thinking however, before introducin a new option like lang, we should have full support for localization in the JSON Editor (context menu, tooltips, JSON errors, etc), not just for the validation errors. Also, like the ajv-i18n is separate from ajv itself, I think it will be best to create a jsoneditor-i18n library separate from jsoneditor itself. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bearmini @josdejong