Fix decryption check condition #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-x` checks for the existence of a file. I think something like `! -z` was intended (`-z` checks for empty string). There is also a `-n` which is equivalent to `! -z`. So switch to `-n` and quote the expansion to avoid syntax errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the decryption check can never fail. The
ifchecks for errors using! -x $DECRYPTION. But-xchecks for the existence of a file. And indeed, some random string never exists as a file, so the printf and exit will always be skipped.I think something like
! -zwas intended (-zchecks for empty string). There is also a-nwhich is equivalent to! -z. So this change switches to-nand quotes the expansion to avoid syntax errors.