Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use Dialog for ContentHistory field #42454

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Dec 3, 2023

Summary of Changes

Use Dialog for ContentHistory field

Testing Instructions

Do frontend Content editing.
Click Versions button to open Content history.
Try to use diferent Content history features in this popup.

Actual result BEFORE applying this Pull Request

Works with BS Modal

Expected result AFTER applying this Pull Request

Works with Joomla Dialog

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

References:

@Fedik Fedik added Feature Small A PR which only has a small change labels Dec 3, 2023
@Fedik Fedik changed the title [5.2] Use Dialog for ContentHistory field [5.1] Use Dialog for ContentHistory field Dec 3, 2023
@Quy
Copy link
Contributor

Quy commented Dec 6, 2023

Before PR:
42454-before

After PR, alert needs padding:
42454-after

@Fedik Fedik requested a review from chmst as a code owner December 7, 2023 08:37
@Fedik
Copy link
Member Author

Fedik commented Dec 7, 2023

@Quy please try again

@Quy
Copy link
Contributor

Quy commented Dec 7, 2023

I have tested this item ✅ successfully on 05184ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42454.

1 similar comment
@fgsw
Copy link

fgsw commented Dec 8, 2023

I have tested this item ✅ successfully on 05184ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42454.

@Quy
Copy link
Contributor

Quy commented Dec 8, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42454.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 8, 2023
@LadySolveig LadySolveig merged commit f36a3e0 into joomla:5.1-dev Dec 15, 2023
2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 15, 2023
@LadySolveig
Copy link
Contributor

Thank you @Fedik 🚀
Many thanks also for testing @Quy @fgsw

@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Dec 15, 2023
@Fedik Fedik deleted the popup-contenthistory branch December 15, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants