Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use Dialog for Field Media and Editor Media button #42288

Merged
merged 11 commits into from
Dec 16, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 4, 2023

Pull Request for Issue # .

Summary of Changes

Update Field Media, and Editor media button to use JoomlaDialog.

Testing Instructions

Run npm install
Edit article and use Media button to insert image to article,
Also try edit "Intro Image" of the article

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

References:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Nov 4, 2023
@Fedik Fedik added the Feature label Nov 4, 2023
@Fedik Fedik marked this pull request as draft November 4, 2023 16:00
@Fedik

This comment was marked as outdated.

@Fedik Fedik marked this pull request as ready for review November 4, 2023 16:06
@Fedik Fedik changed the title [5.1] Field Media and Editor Media button use Dialog [5.1] Use Dialog for Field Media and Editor Media button Nov 5, 2023
@Fedik Fedik changed the base branch from 5.0-dev to 5.1-dev November 6, 2023 11:44
@Quy
Copy link
Contributor

Quy commented Nov 10, 2023

I have tested this item ✅ successfully on bf74e20


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42288.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on bf74e20


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42288.

@joomla-cms-bot joomla-cms-bot changed the title [5.1] Use Dialog for Field Media and Editor Media button [5.1] Use Dialog for Field Media and Editor Media button Nov 11, 2023
@alikon
Copy link
Contributor

alikon commented Nov 11, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42288.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 11, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Dec 16, 2023
@LadySolveig LadySolveig merged commit fc51f46 into joomla:5.1-dev Dec 16, 2023
2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 16, 2023
@LadySolveig
Copy link
Contributor

Thank you @Fedik and also to the testers @Quy @viocassel ! 🎉

@Fedik Fedik deleted the media-select-dialog2 branch December 16, 2023 20:41
@brianteeman brianteeman mentioned this pull request Apr 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants