-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Use Dialog for Field Media and Editor Media button #42288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.0-dev
labels
Nov 4, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Fedik
changed the title
[5.1] Field Media and Editor Media button use Dialog
[5.1] Use Dialog for Field Media and Editor Media button
Nov 5, 2023
Fedik
force-pushed
the
media-select-dialog2
branch
from
November 6, 2023 11:46
eaf1987
to
63d026f
Compare
Quy
reviewed
Nov 6, 2023
I have tested this item ✅ successfully on bf74e20 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42288. |
1 similar comment
I have tested this item ✅ successfully on bf74e20 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42288. |
joomla-cms-bot
changed the title
[5.1] Use Dialog for Field Media and Editor Media button
[5.1] Use Dialog for Field Media and Editor Media button
Nov 11, 2023
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42288. |
Thank you @Fedik and also to the testers @Quy @viocassel ! 🎉 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Update Field Media, and Editor media button to use JoomlaDialog.
Testing Instructions
Run
npm install
Edit article and use Media button to insert image to article,
Also try edit "Intro Image" of the article
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
References: