-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Animation for new dialog #41748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.0-dev
labels
Sep 14, 2023
I have tested this item ✅ successfully on a827687 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41748. |
We need a media query to be turn off the animation similar to https://github.com/joomla/joomla-cms/blob/78bb192670753c46b374cbaf56440a00266892e9/build/media_source/system/scss/joomla-core-loader.scss#L120C1-L124 |
Added |
I have tested this item ✅ successfully on 0d44b06 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41748. |
1 similar comment
I have tested this item ✅ successfully on 0d44b06 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41748. |
richard67
changed the title
[5.0] Animation for new dialog
[5.0] Animation for new dialog
Sep 14, 2023
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41748. |
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
A litle animation for dialog, very similar to bs modal
Testing Instructions
Apply patch, run
npm install
Go to menu, edit menu Single Article, and select Artcile
Actual result BEFORE applying this Pull Request
Dialog without animation
Expected result AFTER applying this Pull Request
Dialog with animation
Link to documentations
Please select:
References: