[4.0] admin menu reduced motion #33069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr for joomla#31242 This is a temp fix until upstream addresses this onokumus/metismenujs#9 The fix applied is the exact same one used by webaim.org so should be acceptable from an a11y perspective. There will be no change for most users. It is only if they have reduced motion set in their operating system that they encounter the problem this fixes.
joomla-cms-bot
added
NPM Resource Changed
|
Maybe a PR upstream would be more useful? |
|
@HLeithner it would be, but upstream hasnt responded yet at all to the issue report filed by @ciar4n |
|
Yes I have seen this, but also see that this repo never got a pull request^^ |
|
@HLeithner one is javascript and one is css. I wouldnt dream of submitting a js pull request. Not sure what you are trying to prove by blocking this one line pull request |
|
I'm not blocking, just try to prevent to add a But yeah doesn't look good for metismenujs maybe we should remove/replace it because it's unmaintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr for #31242
This is a temp fix until upstream addresses this onokumus/metismenujs#9
The fix applied is the exact same one used by webaim.org so should be acceptable from an a11y perspective.
There will be no change for most users. It is only if they have reduced motion set in their operating system that they encounter the problem this fixes.