Storage advisor #3
Conversation
|
|
||
| FROM ubuntu AS bin | ||
|
|
||
| COPY eu-central-1-bundle.crt /usr/local/share/ca-certificates/ |
There was a problem hiding this comment.
I believe we don't need this one - it's only necessary if we're talking to AWS RDS.
|
|
||
| ctx := context.TODO() | ||
| cfg, err := config.LoadDefaultConfig(ctx) | ||
| cfg.Region = "eu-central-1" |
There was a problem hiding this comment.
We probably should not hardcode region.
There was a problem hiding this comment.
Moved to flags but I don't see a reason to host it anywhere outside of eu-1
| cfg, err := config.LoadDefaultConfig(ctx) | ||
| cfg.Region = "eu-central-1" | ||
| if err != nil { | ||
| log.Println("Error:", err) |
There was a problem hiding this comment.
Since this is server-side code, I'd recommend we use zerolog for all logging. It produces json structured output, which is way easier to handle. Also, it has a fatal level, which we can use instead of explicit return or os.exit.
| select { | ||
| case sig := <-sigchan: | ||
| log.Printf("Caught signal %v: terminating\n", sig) | ||
| run = false |
There was a problem hiding this comment.
That's more of stylistic comment - but maybe "while true" look with "break" will be a bit cleaner.
| } | ||
| defer reader.Close() | ||
|
|
||
| err = uploadToS3(cfg, ctx, reader, *bucketName, objectKey) |
There was a problem hiding this comment.
I wonder if we can use S3 CopyObject functionality here? I am not sure if that works with pre-signed URLs, but it if does, it will be more efficient than downloading and uploading.
| @@ -0,0 +1,124 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
There was a problem hiding this comment.
And then we don't need this file.
No description provided.