New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Typescript definitions. #721

Merged

jonobr1 merged 2 commits into jonobr1:dev from kevin-nano:improved-typing

Mar 19, 2024

Contributor

kevin-nano commented Mar 19, 2024

I'm using Typescript with the library and having some typing issues with the library.

Matrix#multiply has some typing issues when trying to multiply a Vector. This patch fixes the overloads of the function.
Added Two.BoundingBox to be able to use the returned object of getBoundingClientRect functions more easily.

kevin-nano added 2 commits

March 19, 2024 12:29


          Added overloaded definitions for Matrix#multiply.

11bc5d9


          Added Two.BoundingBox.

dc20c58

Owner

jonobr1 commented Mar 19, 2024

Awesome, thank you!

jonobr1 merged commit eb50447 into jonobr1:dev

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet