Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to VS2022 #5107

Closed
wants to merge 3 commits into from
Closed

Upgrade to VS2022 #5107

wants to merge 3 commits into from

Conversation

aybe
Copy link
Collaborator

@aybe aybe commented Jul 9, 2024

Does this PR introduce new feature(s)?

Upgrade project to VS2022.

Also, enabled edit and continue for Windows/Debug builds as it's really a time saver.

aybe added 2 commits July 8, 2024 21:37
@joncampbell123
Copy link
Owner

joncampbell123 commented Jul 9, 2024

Everyone here OK with moving on from VS2019?

@maron2000
Copy link
Contributor

maron2000 commented Jul 9, 2024

We can add a CI workflow to confirm that the future codes is still buildable on VS2019, just like the C++11 check on Linux builds.
Currently, nightly builds are built on VS2017 and 2019.

@aybe
Copy link
Collaborator Author

aybe commented Jul 9, 2024

Currently, one has to:

  • be careful to not commit these every time
  • when stashing these, VS always wants to reload solution after unstashing

Not the end of the world but if this could be avoided that'd be great.

However, in no way there should be two VS solutions, a sure recipe for extra confusion when updating them.

@maron2000
Copy link
Contributor

maron2000 commented Jul 9, 2024

Well the only problem I can think of is that if you upgrade to VS2022, VS2019 users can no longer build without reverting the build tool settings, and slight incompatibilities exist between the two tools.

Other than that, I personally feel that we can go ahead to upgrade the build tool.

Nightly builds can flexibly change the build tools.
Already switching between v141(2017) and v142(2019) is done to build XP builds, and switching from v143(2022) will not be a problem.

Edit: I'm not saying we should upload all three builds, but only two, the Standard (v143) and XP (v141).

@aybe
Copy link
Collaborator Author

aybe commented Jul 9, 2024

After switching branches, I noticed this:

image

I thought, okay, let's try that instead...

Well... they are making it really hard to get it these days:

image

After searching... winget can get it to install and show up in VS installer:

https://winstall.app/apps/Microsoft.VisualStudio.2019.BuildTools

But it will only work once you do that:

image

So yeah, it's possible to stay on 2019 while using 2022 but it's tedious to do so.

@aybe
Copy link
Collaborator Author

aybe commented Jul 9, 2024

Just made a simpler PR for ENC on 2019 instead of that one. #5110

Ideally, 2022 switch would be better, but if not ready then it can be postponed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants