Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VHD geometry patches #4590

Merged
merged 2 commits into from
Nov 8, 2023
Merged

VHD geometry patches #4590

merged 2 commits into from
Nov 8, 2023

Conversation

maxpat78
Copy link
Contributor

@maxpat78 maxpat78 commented Nov 7, 2023

  • bios_vhd.cpp now detects real MBR/BPB geometry or, at least, returns a default C/255/63 one coherent with IMGMAKE; calcDiskSize is dropped in favor of footer.currentSize (a VHD can reach 2040GB, while pseudo-CHS geometry is limited to 127GB)

  • IMGMAKE/IMGMOUNT behavior is reverted back to "old" (pre-May 2023) DosBox-X default

Fixes #4589 and probably #4541

- bios_vhd.cpp now detects real MBR/BPB geometry or, at least, returns a default C/255/63 one coherent with IMGMAKE
- calcDiskSize is dropped in favor of footer.currentSize (a VHD can reach 2040GB, while pseudo-CHS geometry is limited to 127GB)
- IMGMAKE/IMGMOUNT behavior is reverted to old DosBox-X default
Mention Italian translation
@joncampbell123 joncampbell123 merged commit 77b9b7a into joncampbell123:master Nov 8, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buggy C-H-S access in VHD driver
2 participants