feat: handle booleans more gracefully #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranVanBelle
force-pushed
the
feat/handle-booleans-more-gracefully
branch
5 times, most recently
from
6b559d8 to
4d6a2af
Compare
jonas-grgt
reviewed
Apr 24, 2024
| @@ -58,12 +59,15 @@ public List<SetterMethodDefinition> getSetterMethods() { | |||
| for (FieldDefinition field : fields) { | |||
| String name = field.name().substring(0, 1).toUpperCase() + field.name().substring(1); | |||
| methodsWithOneParam.stream() | |||
| .filter(m -> m.name().equals(field.name())) | |||
| .filter(m -> m.name().equals(field.name()) || (m.name().equals(field.name().substring(2)) | |||
There was a problem hiding this comment.
I would like to see a stronger check by first verifying if the field name starts with "is" and afterwards check it for equality by stripping the first two chars.
JoranVanBelle
force-pushed
the
feat/handle-booleans-more-gracefully
branch
4 times, most recently
from
28421ef to
cfc6097
Compare
JoranVanBelle
force-pushed
the
feat/handle-booleans-more-gracefully
branch
5 times, most recently
from
3d6372c to
484c561
Compare
JoranVanBelle
force-pushed
the
feat/handle-booleans-more-gracefully
branch
from
484c561 to
7f99bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21