-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option for max_sequence_length of video generation #699
Conversation
docs/options.md
Outdated
@@ -70,7 +70,7 @@ Here are all the available options to call with `train.py` | |||
| --G_unet_mha_num_heads | int | 1 | number of heads in the mha architecture | | |||
| --G_unet_mha_res_blocks | array | [2, 2, 2, 2] | distribution of resnet blocks across the UNet stages, should have same size as --G_unet_mha_channel_mults | | |||
| --G_unet_mha_vit_efficient | flag | | if true, use efficient attention in UNet and UViT | | |||
| --G_unet_vid_max_frame | int | 24 | max frame number for unet_vid in the PositionalEncoding | | |||
| --vid_max_sequence_length | int | 25 | max frame number for unet_vid in the PositionalEncoding | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename --G_unet_vid_max_sequence_length
since this is a property of the unet_vid architecture, not the data or the video.
docs/source/options.rst
Outdated
@@ -130,7 +130,7 @@ Generator | |||
+------------------------------------------------+-----------------+---------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | |||
| --G_unet_mha_vit_efficient | flag | | if true, use efficient attention in UNet and UViT | | |||
+------------------------------------------------+-----------------+---------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | |||
| --G_unet_vid_max_frame | int | 24 | max frame number for unet_vid in the PositionalEncoding | | |||
| --vid_max_sequence_length | int | 25 | max frame number for unet_vid in the PositionalEncoding | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't modify, this is generated automatically.
@@ -379,7 +379,7 @@ def __init__( | |||
attention_block_types=("Temporal_Self", "Temporal_Self"), | |||
cross_frame_attention_mode=None, | |||
temporal_position_encoding=False, | |||
temporal_position_encoding_max_len=25, | |||
temporal_position_encoding_max_len=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the default 25 value because None cannot work, and should not be used for init.
@@ -439,7 +438,7 @@ def __init__( | |||
upcast_attention=False, | |||
cross_frame_attention_mode=None, | |||
temporal_position_encoding=False, | |||
temporal_position_encoding_max_len=25, | |||
temporal_position_encoding_max_len=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set default value instead
code works with |
b718c8c
to
9f0b76a
Compare
9f0b76a
to
efa0e8c
Compare
Create an option for the maximum sequence length for video generation, --vid_max_sequence_length. The data_temporal_number_frames value should not exceed --vid_max_sequence_length
Example of execution. It works with: