Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random canny in batch #683

Merged
merged 2 commits into from
Sep 17, 2024
Merged

random canny in batch #683

merged 2 commits into from
Sep 17, 2024

Conversation

wr0124
Copy link
Collaborator

@wr0124 wr0124 commented Sep 3, 2024

Generate random Canny edges for a batch of images in the sequence.

@wr0124 wr0124 changed the title random canny in one sequence random canny in one sequence for vid Sep 3, 2024
@wr0124 wr0124 requested review from royale and beniz September 3, 2024 13:15
@wr0124 wr0124 force-pushed the canny_random branch 2 times, most recently from b3197e6 to 13c469b Compare September 13, 2024 07:02
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using the original method fill_img_with_random_sketch, the inputs gt_image and mask need to be sliced to process them one by one to produce random Canny. Using two loops would not be efficient. How do you think to change the method fill_img_with_random_sketch by adding some additional variable to make it more flexible for all the case?(random canny/fixed canny/dropout canny)

@wr0124 wr0124 changed the title random canny in one sequence for vid random canny in batch Sep 13, 2024
feat(ml): canny random
@beniz beniz merged commit b68ab53 into jolibrain:master Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants