feat(ml): optim weigth decay parameter control #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniz
force-pushed
the
feat_optim_weight_decay
branch
3 times, most recently
from
d0de2f9
to
35ef0fa
Compare
royale
reviewed
Oct 4, 2023
train.py
Outdated
| print("Using ", opt.train_optim, " as optimizer") | ||
| if opt.train_optim == "adam": | ||
| return torch.optim.Adam(params, lr, betas) | ||
| return torch.optim.Adam(params, lr, betas, weight_decay) |
There was a problem hiding this comment.
weight_decay is 5th param: https://pytorch.org/docs/stable/generated/torch.optim.Adam.html
beniz
force-pushed
the
feat_optim_weight_decay
branch
from
35ef0fa
to
2bba1a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.