Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Adds building-number(건물 번호) to a road address in 'ko_KR' locale. Without building-numbers, faker-generated addresses do not reflect real addressing system in Republic of Korea(South korea).
before:
address form:
"{{road_name}}{{road_suffix}}"
대전광역시 강서구 석촌호수거리
after:
below shows one of possible outputs
(FYI, 석촌호수거리 is a road name.)
Change above also applies to the other form of an address, which is defined as :
"{{road_name}}{{road_number}}{{road_suffix}}"
.What was wrong
The original source code did not include any logic to generate building numbers. Although it is explained on comments written on source code.
How this fixes it
Added additional strings to describe building numbers.
Fixes #2132
Checklist
make lint