Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix korean road address #2133

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

semi-yu
Copy link
Contributor

@semi-yu semi-yu commented Nov 2, 2024

What does this change

Adds building-number(건물 번호) to a road address in 'ko_KR' locale. Without building-numbers, faker-generated addresses do not reflect real addressing system in Republic of Korea(South korea).

before:
address form: "{{road_name}}{{road_suffix}}"
대전광역시 강서구 석촌호수거리

after:
below shows one of possible outputs

  • 대전광역시 강서구 석촌호수거리 110 (Basic building number format)
  • 대전광역시 강서구 석촌호수거리 지하110 (The building's main entrance is underground)
  • 대전광역시 강서구 석촌호수거리 110-31 (The building is cramped together, distinguished by sub-building number; exact format is (main-building-number)-(sub-building-number))

(FYI, 석촌호수거리 is a road name.)

Change above also applies to the other form of an address, which is defined as : "{{road_name}}{{road_number}}{{road_suffix}}".

What was wrong

The original source code did not include any logic to generate building numbers. Although it is explained on comments written on source code.

How this fixes it

Added additional strings to describe building numbers.

Fixes #2132

Checklist

  • I have read the documentation about CONTRIBUTING
  • I have read the documentation about Coding style
  • I have run make lint

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 901fb6a into joke2k:master Nov 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

road_address for ko_KR locale should be changed
2 participants