Allow extension in file_path to take a list of allowed extensions, or empty for "no extension" #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotofritz
force-pushed
the
fix/master/1964_paths
branch
from
e2809b8
to
a3e973d
Compare
fcurella
reviewed
Dec 28, 2023
faker/providers/file/__init__.py
Outdated
| """ | ||
| no_extension = False | ||
| if isinstance(extension, list): |
There was a problem hiding this comment.
I'd like for extension to also possibly a tuple.
We could type the argument with extension: Optional[Sequence[str]], and then check for not isinstance(extension, str) instead:
Suggested change
| if isinstance(extension, list): | |
| if not isinstance(extension, str): |
I would also change the behavior of file_name, so that if the empty string is passed, no extension and no dot are added. This would allow us to pass "" to file_name and avoid stripping it out later.
There was a problem hiding this comment.
Done - also checking for None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Change to file_path behaviour: allow extension to take a list of allowed extensions, or empty for "no extension". Non-breaking change.
What was wrong
There was no way to have a path without extension
How this fixes it
As proposed by @joke2k, passing a list allows to have no extension is list is empty, but it also allows the user to provide a list of candidate extensions from which to pick one.
Fixes #1964