Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature yoruba names and colors #1905

Closed

Conversation

21toffy
Copy link

@21toffy 21toffy commented Sep 5, 2023

What does this change

Brief summary of the changes.

What was wrong

Description of the root cause of the issue.

How this fixes it

Description of how the changes fix the issue.

Fixes #...

Will0177 and others added 3 commits September 4, 2023 20:41
…NG) locale within the Python Faker package. The new provider enhances the package's capabilities, enabling the generation of Yoruba-specific person-related data such as names and colors.

The person provider for yo_NG includes:
- Yoruba names (first names and last names)
- Yoruba-specific colors

This addition extends the versatility of Python Faker by supporting Yoruba language-specific data generation, facilitating various testing and development tasks that require Yoruba person-related information.

Contributor: Tofunmi Okedeji
The addition of these tests enhances the reliability and quality of Yoruba color data generation in the Python Faker library, ensuring that it aligns with Yoruba language conventions and expectations.

Contributor: Tofunmi Okedeji
@21toffy
Copy link
Author

21toffy commented Sep 5, 2023

What does this change:
This PR introduces updates to add Yoruba names, colors, and a person provider for the yo_NG locale to the project. It includes the following updates:

  • Added Yoruba names for better localization.
  • Included Yoruba color names to enhance language support.
  • Implemented a person provider for the yo_NG locale, enabling realistic and localized data generation.

What was wrong:
Previously, the project lacked proper support for the Yoruba language, which limited its usability for Yoruba-speaking users. The absence of Yoruba names, colors, and person generation made it challenging for users who prefer or require Yoruba content.

How this fixes it:
This PR addresses these issues by adding comprehensive support for the Yoruba language. The changes enable the project to provide:

  • Yoruba names for users.
  • Yoruba color names for localization.
  • Realistic and culturally appropriate person data generation for Yoruba-speaking locales.


formats = formats_female + formats_male

first_names_male = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our coding guidelines require a source for this data. Can you include the source for these list of names?

@@ -195,6 +195,7 @@ class Provider(BaseProvider):
"Yoruba",
"Zhuang",
"Chinese",
"yoruba"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in title case?

@github-actions github-actions bot added the stale label Dec 5, 2023
@github-actions github-actions bot closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants