-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature yoruba names and colors #1905
Conversation
…NG) locale within the Python Faker package. The new provider enhances the package's capabilities, enabling the generation of Yoruba-specific person-related data such as names and colors. The person provider for yo_NG includes: - Yoruba names (first names and last names) - Yoruba-specific colors This addition extends the versatility of Python Faker by supporting Yoruba language-specific data generation, facilitating various testing and development tasks that require Yoruba person-related information. Contributor: Tofunmi Okedeji
The addition of these tests enhances the reliability and quality of Yoruba color data generation in the Python Faker library, ensuring that it aligns with Yoruba language conventions and expectations. Contributor: Tofunmi Okedeji
What does this change:
What was wrong: How this fixes it:
|
|
||
formats = formats_female + formats_male | ||
|
||
first_names_male = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our coding guidelines require a source for this data. Can you include the source for these list of names?
@@ -195,6 +195,7 @@ class Provider(BaseProvider): | |||
"Yoruba", | |||
"Zhuang", | |||
"Chinese", | |||
"yoruba" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in title case?
What does this change
Brief summary of the changes.
What was wrong
Description of the root cause of the issue.
How this fixes it
Description of how the changes fix the issue.
Fixes #...