Additional pseudo-random color fakes #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdemmer
changed the title
fdemmer
force-pushed
the
fix/master/additional_color_fakes
branch
from
e6d7468
to
550d9ba
Compare
fcurella
requested changes
Sep 7, 2023
I did, but it did not find any issues; I suspect there was another issue with the pipeline before 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Add
color_rgb,color_rgb_float,color_hsvandcolor_hslfakesWhat was wrong
Pseudo-random colors were only available as strings.
How this fixes it
Additional fakes provide tuples of int/float.
Fixes #1903