fix: random sign in pyfloat when positive=False (#1954)

joke2k · Dec 13, 2023 · 1ff3186 · 1ff3186
1 parent efc91d5
commit 1ff3186
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/faker/providers/python/__init__.py b/faker/providers/python/__init__.py
@@ -141,7 +141,7 @@ def pyfloat(
         self,
         left_digits=None,
         right_digits=None,
-        positive=False,
+        positive=None,
         min_value=None,
         max_value=None,
     ):
@@ -203,7 +203,14 @@ def pyfloat(
                 positive,
             )
         else:
-            sign = "+" if positive else self.random_element(("+", "-"))
+            if positive is None:
+                sign = self.random_element(("+", "-"))
+            elif positive is True:
+                sign = "+"
+            else:
+                sign = "-"
+
+
             left_number = self.random_number(left_digits)
 
         result = float(f"{sign}{left_number}.{self.random_number(right_digits)}")