finally finished lab #225
Open
finally finished lab #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angiepmunoz
reviewed
Oct 24, 2022
| result -= Number(newArg[i]) | ||
| } | ||
| return result | ||
| } if (process.argv[2] !== "plus" || process.argv[2] !== "minus") { |
There was a problem hiding this comment.
modulo is hardcoded here. What if I use the operator division?
If i run node run.js 1 2 3, I get Invalid operation: modulo. How can you update this conditional to make sure you get the correct error message?
| } if (process.argv[2] === "plus") { | ||
| let newArg = process.argv.slice(3); | ||
| let sum = 0; | ||
| sum = newArg.reduce((accumulator, value) => { |
There was a problem hiding this comment.
you can declare sum here instead of line 27 so : let sum = newArg.reduce(...)
| } if( process.argv[2] === 'minus'){ | ||
| let newArg = process.argv.slice(3); | ||
| let result = newArg[0] | ||
| for(let i = 1; i < newArg.length; i++){ |
There was a problem hiding this comment.
with reduce and this loop, you have two accumulators, how can you refactor your code to not be repetitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.