Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added missing commons-lang3 library and project files for IDEA #68

Merged
merged 4 commits into from
Jan 14, 2022
Merged

added missing commons-lang3 library and project files for IDEA #68

merged 4 commits into from
Jan 14, 2022

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Jan 11, 2022 •
edited by johnthagen
Loading

Closes #66

@johnthagen
Copy link
Owner

@firewave Are you able to check if this builds on Windows under latest IntelliJ IDEA?

@firewave
Copy link
Collaborator Author

That's what I am doing. Windows 10 and IDEA 2021.3.1. Possibly another file within the .idea folder which needs to be added to the repo.

@firewave
Copy link
Collaborator Author

I checked some other plugins and the whole .idea folder was missing so there was no project at all after my last changes. This might also explain why I had some trouble getting this to work when I started building it.

@firewave firewave changed the title added missing commons-lang3 library for IDEA added missing commons-lang3 library and project files for IDEA Jan 11, 2022
@johnthagen johnthagen self-requested a review January 14, 2022 12:42
johnthagen
johnthagen approved these changes Jan 14, 2022
View reviewed changes
Copy link
Owner

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on Windows 10.

@johnthagen johnthagen merged commit 6a63a64 into johnthagen:master Jan 14, 2022
@johnthagen johnthagen mentioned this pull request Jan 14, 2022
Open
4 tasks
@johnthagen
Copy link
Owner

@firewave I submitted 1.6.1 for moderation. I also opened #69 to track the Gradle migration if you are interested in looking into that, it would be appreciated.

@firewave firewave deleted the lang3-fix branch January 14, 2022 15:43
@johnthagen
Copy link
Owner

1.6.1 is now live: https://plugins.jetbrains.com/plugin/8143-cppcheck/versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnthagen johnthagen johnthagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build 1.6.0 on Windows
2 participants
@firewave @johnthagen