Dumping of invocation stats.

johnno1962 · Oct 14, 2020 · 4bd64cf · 4bd64cf
1 parent e27960d
commit 4bd64cf
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 4 deletions.
diff --git a/InjectionBundle/InjectionClient.h b/InjectionBundle/InjectionClient.h
@@ -37,6 +37,7 @@ typedef NS_ENUM(int, InjectionCommand) {
  InjectionTraceFramework,
  InjectionInclude,
  InjectionExclude,
+ InjectionStats,
 
  InjectionInvalid = 1000,
 

diff --git a/InjectionBundle/InjectionClient.mm b/InjectionBundle/InjectionClient.mm
@@ -5,7 +5,7 @@
 // Created by John Holdsworth on 06/11/2017.
 // Copyright © 2017 John Holdsworth. All rights reserved.
 //
-// $Id: //depot/ResidentEval/InjectionBundle/InjectionClient.mm#113 $
+// $Id: //depot/ResidentEval/InjectionBundle/InjectionClient.mm#115 $
 //
 
 #import "InjectionClient.h"
@@ -283,6 +283,12 @@ - (void)runInBackground {
  [SwiftTrace setSwiftTraceFilterExclude:[self readString]];
  [self filteringChanged];
  break;
+ case InjectionStats:
+ if (!tracing)
+ printf("💉 ⚠️ You need to have traced something to gather stats.\n");
+ else
+ [SwiftInjection dumpStats];
+ break;
  case InjectionInvalid:
  printf("💉 ⚠️ Connection rejected. Are you running the correct version of InjectionIII.app from /Applications? ⚠️\n");
  break;

diff --git a/InjectionBundle/SwiftInjection.swift b/InjectionBundle/SwiftInjection.swift
@@ -5,7 +5,7 @@
 // Created by John Holdsworth on 05/11/2017.
 // Copyright © 2017 John Holdsworth. All rights reserved.
 //
-// $Id: //depot/ResidentEval/InjectionBundle/SwiftInjection.swift#78 $
+// $Id: //depot/ResidentEval/InjectionBundle/SwiftInjection.swift#84 $
 //
 // Cut-down version of code injection in Swift. Uses code
 // from SwiftEval.swift to recompile and reload class.
@@ -339,6 +339,18 @@ public class SwiftInjection: NSObject {
  free(methods)
  }
  }
+
+ @objc class func dumpStats() {
+ print("""
+
+ Sorted elapsed time/invocations by method
+ =========================================
+ """)
+ let invocationCounts = SwiftTrace.invocationCounts()
+ for (method, elapsed) in SwiftTrace.sortedElapsedTimes(onlyFirst: 1000) {
+ print("\(String(format: "%.1f", elapsed*1000.0))ms/\(invocationCounts[method] ?? -1)\t\(method)")
+ }
+ }
 }
 
 class SwiftSweeper {

diff --git a/InjectionIII/AppDelegate.swift b/InjectionIII/AppDelegate.swift
@@ -5,7 +5,7 @@
 // Created by John Holdsworth on 06/11/2017.
 // Copyright © 2017 John Holdsworth. All rights reserved.
 //
-// $Id: //depot/ResidentEval/InjectionIII/AppDelegate.swift#70 $
+// $Id: //depot/ResidentEval/InjectionIII/AppDelegate.swift#71 $
 //
 
 import Cocoa
@@ -300,6 +300,11 @@ class AppDelegate : NSObject, NSApplicationDelegate {
  lastConnection?.sendCommand(.traceSwiftUI, with: nil)
  }
 
+ @IBAction func traceStats(_ sender: NSMenuItem) {
+ toggleState(sender)
+ lastConnection?.sendCommand(.stats, with: nil)
+ }
+
  @IBAction func showTraceFilters(_ sender: NSMenuItem?) {
  NSApplication.shared.activate(ignoringOtherApps: true)
  traceFilters.makeKeyAndOrderFront(sender)

diff --git a/InjectionIII/Base.lproj/MainMenu.xib b/InjectionIII/Base.lproj/MainMenu.xib
@@ -771,6 +771,14 @@
  <action selector="traceSwiftUI:" target="Voe-Tx-rLC" id="0xk-LY-4Pv"/>
  </connections>
  </menuItem>
+ <menuItem isSeparatorItem="YES" id="1Zk-TV-Nfy"/>
+ <menuItem title="Dump Stats" toolTip="Dump elpased time stats per method." id="wMb-mC-poo">
+ <modifierMask key="keyEquivalentModifierMask"/>
+ <accessibility description="Trace App"/>
+ <connections>
+ <action selector="traceStats:" target="Voe-Tx-rLC" id="2DR-dQ-dhn"/>
+ </connections>
+ </menuItem>
  <menuItem title="Set Filters" toolTip="Set filters to manage trace output." id="Y20-on-vxe">
  <modifierMask key="keyEquivalentModifierMask"/>
  <accessibility description="Trace App"/>

diff --git a/InjectionIII/Info.plist b/InjectionIII/Info.plist
@@ -19,7 +19,7 @@
  <key>CFBundleShortVersionString</key>
  <string>$(MARKETING_VERSION)</string>
  <key>CFBundleVersion</key>
- <string>4391</string>
+ <string>4401</string>
  <key>LSApplicationCategoryType</key>
  <string>public.app-category.developer-tools</string>
  <key>LSMinimumSystemVersion</key>