Add insecure option #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notartom
force-pushed
the
master
branch
4 times, most recently
from
a88af7e to
e91e2d5
Compare
This option, defaulted to false, passes `-k` to curl and allows it to work in cases where the website being checked is deployed with self-signed certificates in CI. `insecure` is inserted as the first argument to the script to minimize unexpected behavior in case the scan_text has whitespace that has not been escaped by mistake. Consider the following example: scan-website.sh https://example.com/ text with whitespace true Had we used insecure=$3, we'd have ended up with insecure="with", which would run curl without `-k` and presumably fail in a mysterious way.
|
Finally got a working version of this here: https://github.com/LibriVox/librivox-ansible/actions/runs/7326431956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option, defaulted to false, passes
-kto curl and allows it to work incases where the website being checked is deployed with self-signed certificates
in CI.