Remove unneeded :app:Highlight model class.

+ AppRepository#readHighlights is only invoked within the scope of database models in AppRepository#loadSessionsForDayIndex. Hence, there is no reason to convert the returned :database:Highlight to :app:Highlight.
johnjohndoe · Jun 28, 2024 · 96214ab · 96214ab
1 parent 073dc28
commit 96214ab
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 48 deletions.
diff --git a/app/src/main/java/nerd/tuxmobil/fahrplan/congress/dataconverters/HighlightExtensions.kt b/app/src/main/java/nerd/tuxmobil/fahrplan/congress/dataconverters/HighlightExtensions.kt
diff --git a/app/src/main/java/nerd/tuxmobil/fahrplan/congress/dataconverters/HighlightsExtensions.kt b/app/src/main/java/nerd/tuxmobil/fahrplan/congress/dataconverters/HighlightsExtensions.kt
diff --git a/app/src/main/java/nerd/tuxmobil/fahrplan/congress/models/Highlight.kt b/app/src/main/java/nerd/tuxmobil/fahrplan/congress/models/Highlight.kt
diff --git a/app/src/main/java/nerd/tuxmobil/fahrplan/congress/repositories/AppRepository.kt b/app/src/main/java/nerd/tuxmobil/fahrplan/congress/repositories/AppRepository.kt
@@ -38,7 +38,6 @@ import nerd.tuxmobil.fahrplan.congress.dataconverters.toDateInfos
 import nerd.tuxmobil.fahrplan.congress.dataconverters.toDayIndices
 import nerd.tuxmobil.fahrplan.congress.dataconverters.toDayRanges
 import nerd.tuxmobil.fahrplan.congress.dataconverters.toHighlightDatabaseModel
-import nerd.tuxmobil.fahrplan.congress.dataconverters.toHighlightsAppModel
 import nerd.tuxmobil.fahrplan.congress.dataconverters.toMetaAppModel
 import nerd.tuxmobil.fahrplan.congress.dataconverters.toMetaDatabaseModel
 import nerd.tuxmobil.fahrplan.congress.dataconverters.toMetaNetworkModel
@@ -703,7 +702,7 @@ object AppRepository {
     }
 
     private fun readHighlights() =
-            highlightsDatabaseRepository.query().toHighlightsAppModel()
+            highlightsDatabaseRepository.query()
 
     @WorkerThread
     fun updateHighlight(session: SessionAppModel) {

diff --git a/app/src/test/java/nerd/tuxmobil/fahrplan/congress/dataconverters/HighlightExtensionsTest.kt b/app/src/test/java/nerd/tuxmobil/fahrplan/congress/dataconverters/HighlightExtensionsTest.kt