Restore GitHub Action for building Debian package #1065
Conversation
.github/workflows/deb.yml
Outdated
| # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - run: sudo apt install build-essential debhelper meson gettext pkg-config libglib2.0-dev gjs appstream |
There was a problem hiding this comment.
In my computer, it does not build without the new build dependencies added here (they were not necessary in Foliate version 2).
There was a problem hiding this comment.
Ah, now it does not build because Ubuntu 22.04 repositories have too old versions of gjs (and probably other software too). We probably need to wait for 24.04 GitHub action image so that it can generate a deb package.
There was a problem hiding this comment.
Or add an option to skip the dependency checks. But that makes no sense, either. Those dependencies are supposed to be run-time dependencies. Either we're using Meson wrong and should specify run-time dependencies another way, or Meson should be skipping these checks automatically when building a package.
There was a problem hiding this comment.
I don't think we're doing anything wrong, cause Meson says:
Run-time dependency gjs-1.0 found: YES 1.78.0
Run-time dependency gtk4 found: YES 4.12.3
Run-time dependency libadwaita-1 found: YES 1.4.0
Run-time dependency webkitgtk-6.0 found: YES 2.42.2
So they are run-time dependencies indeed.
This means it could be the same bug that requires you to install desktop-file-utils.
johnfactotum
force-pushed
the
github-action-deb
branch
2 times, most recently
from
5bf02d2
to
a1a8edf
Compare
|
I believe I can help here. Why do you want to build a Debian package? There are different reasons and they might mean we handle this in different ways. Here are some:
Also, the commit message says Debian but this is actually being built on Ubuntu. |
|
The action existed in v2.x. It was mainly for providing a deb package (nightly or otherwise), though it did also function as a check.
Well, I used the term "Debian package" to refer to the deb format. But it was mainly intended for Ubuntu. |
|
@johnfactotum It should work with the new 24.04 based builder github/roadmap#958 |
johnfactotum
force-pushed
the
github-action-deb
branch
from
4c265d1
to
a320cc8
Compare
This reverts commit a320cc8.
|
The action seems to be stuck for some reason https://github.com/johnfactotum/foliate/actions/runs/8918176680/job/24492363460?pr=1065 |
|
Adding Ubuntu 24.04 CI is on Github's roadmap. I haven't seen an announcement that it is enabled yet. |
|
The GitHub action is working after 1. installing build dependencies, 2. fixing debhelper-compat version, and 3. checking out the submodules. Here is my code. archisman-panigrahi#1 |
|
@archisman-panigrahi Yes, please. Thanks! Also I see there's a deprecation notice on actions/upload-artifact v2. Is that fixable by simply changing the version to v4? |
Yes it got fixed this way. Here is my PR #1383 |
* Update dependencies for github action for deb package * debhelper-compat does not work with >= * pull submodules * Update upload-artifact version
No description provided.