[ruby] Ignore "Throwaway" AST Structures #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes AST trees would be thrown away, specifically when long chained expressions would be compressed into temporary cache variables. This only happens with expressions, and closures typically write directly to the diff graph. This PR minimizes what is written directly to the diff graph from function creation, and extends `x2cpg.Ast` to also include `CAPTURE` edges. This also introduces `closureToRefs` map to track which `Block` nodes already have live method ASTs in the diff graph.
AndreiDreyer
reviewed
Oct 1, 2024
| case _ => | ||
| astForExpression(baseNode).nodes |
There was a problem hiding this comment.
Why have we removed this?
There was a problem hiding this comment.
It can be attributed to quite the performance slowdown for these long chained calls, especially as base and receiver are often the same long tree for these chained calls. I initially found it to be the cause for generating about 250 TypeRefs that were thrown away, so I think we can simply rely on non-nested nodes to give us the type hint.
AndreiDreyer
approved these changes
Oct 1, 2024
|
Seems this may have introduced |
DavidBakerEffendi
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit 3c27bf6.
DavidBakerEffendi
added a commit
that referenced
this pull request
Oct 1, 2024
DavidBakerEffendi
added a commit
that referenced
this pull request
Oct 2, 2024
DavidBakerEffendi
added a commit
that referenced
this pull request
Oct 2, 2024
This correctly prevents re-use of nodes that are already being used elsewhere by ensuring deep copies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes AST trees would be thrown away, specifically when long chained expressions would be compressed into temporary cache variables. Sometimes the ASTs that are thrown away, have nodes directly written to the diff graph. This only happens with expressions, and closures typically write directly to the diff graph.
This PR minimizes what is written directly to the diff graph from function creation, and extends
x2cpg.Astto also includeCAPTUREedges. This also introducesclosureToRefsmap to track whichBlocknodes already have live method ASTs in the diff graph.