Progressively enhanced combobox for developer specialties (#820) #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes requesting a bunch of assets via Active Storage can hit the rate limit.
…nabled_controller
…into 820-progressively-enhanced-combobox-for-developer-specialties
MiaSinek
changed the title
3 tasks
|
Hey @MiaSinek - thanks again for your patience on this PR. I'm enabling developer specialties BETA soon and am hoping to address this PR very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Desktop - Javascript enabled
Desktop - Javascript disabled
Mobile - Javascript enabled
Mobile - Javascript disabled
Filtering functionality is not working, because opening the filter sidebar requires Javascript
PR Summary 🌟
This PR is addressing issue #820.
Introducing a new dropdown component!
I created a shiny new component for displaying dropdowns featuring various specialties. Now, both query_component and query_mobile_component make use of it, instead of rendering them separately. 🎉
Magical new controller for pills! 💊
I crafted a powerful controller that takes care of adding and removing specialties, displaying them as pills above the Specialty search field. It'll also ensure the seamless syncing of checkboxes and their states. Because of this, the search URL can be reloaded/bookmarked, and the pill state is restored correctly. 🧙
Form autosubmit refactoring for better control! 🎛️
By enhancing the forms-autosubmit, I enable you to debounce form submissions in other instances. This way, we reduce code duplication and give you more control over submission frequency! 🚀
Easier developer filtering experience! 🔍
Your life just got easier! Now, the update allows you to filter developers based on their specialty. The search results have also received an upgrade, leading to a refreshing new interface. 🥳
Pull request checklist
bin/check